Skip to content

feat(config): allow configuring output file from config #829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
orhun merged 3 commits into from
Sep 21, 2024
Merged

feat(config): allow configuring output file from config #829

orhun merged 3 commits into from
Sep 21, 2024

Conversation

@orhun
Copy link
Owner

@orhun orhun commented Aug 30, 2024

Description

This PR adds a new configuration option as follows:

[changelog]
output = "CHANGELOG.md"

It does not take precedence over command-line arguments which means you can override it with the --output option.

Motivation and Context

closes #827

How Has This Been Tested?

Locally.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@orhun orhun mentioned this pull request Aug 30, 2024
Closed
1 task
@codecov-commenter
Copy link

codecov-commenter commented Aug 30, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 40.04%. Comparing base (c34aaa0) to head (0a5de54).
Report is 30 commits behind head on main.

Files with missing lines Patch % Lines
git-cliff/src/lib.rs 0.00% 5 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #829      +/-   ##
==========================================
- Coverage   40.19%   40.04%   -0.14%     
==========================================
  Files          20       20              
  Lines        1645     1646       +1     
==========================================
- Hits          661      659       -2     
- Misses        984      987       +3
Flag Coverage Δ
unit-tests 40.04% <0.00%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orhun orhun merged commit c2db791 into main Sep 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add output file configuration option

3 participants

@orhun @codecov-commenter