Skip to content

fix(changelog): don't change the context when provided via --from-context #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
orhun merged 1 commit into from
Aug 26, 2024
Merged

fix(changelog): don't change the context when provided via --from-context #820

orhun merged 1 commit into from
Aug 26, 2024

Conversation

@weichweich
Copy link
Contributor

@weichweich weichweich commented Aug 26, 2024

closes /issues/819

Description

A method is added that only adds the additional context remote inside the Changelog struct and does not query commit information.

Motivation and Context

see issue /issues/819

How Has This Been Tested?

I created a changelog and checked that the Gitlab PR information are not changed.

Screenshots / Logs (if applicable)

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov-commenter
Copy link

codecov-commenter commented Aug 26, 2024 •
edited
Loading

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 40.13%. Comparing base (7415289) to head (956d3d0).
⚠️ Report is 260 commits behind head on main.

Files with missing lines Patch % Lines
git-cliff/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #820      +/-   ##
==========================================
+ Coverage   40.02%   40.13%   +0.11%     
==========================================
  Files          20       20              
  Lines        1642     1645       +3     
==========================================
+ Hits          657      660       +3     
  Misses        985      985
Flag Coverage Δ
unit-tests 40.13% <83.34%> (+0.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@orhun orhun marked this pull request as ready for review August 26, 2024 18:06
@orhun orhun self-requested a review as a code owner August 26, 2024 18:06
orhun
orhun approved these changes Aug 26, 2024
View reviewed changes
Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@orhun orhun changed the title fix: don't change the context when a it is provided with --from-context fix(changelog): don't change the context when provided via --from-context Aug 26, 2024
@orhun orhun merged commit ff72406 into orhun:main Aug 26, 2024
@weichweich weichweich deleted the dont-overwrite-pr-information branch August 27, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@orhun orhun orhun approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PR information is discarded when using --from-context

3 participants

@weichweich @codecov-commenter @orhun