Skip to content

Conversation

@marcoieni
Copy link
Contributor

Description

Motivation and Context

git-cliff-core doesn't compile without default features

How Has This Been Tested?

  1. create a new project
  2. add to the Cargo.toml: git-cliff-core = { version = "=2.8.0", default-features = false }
  3. run cargo check. Error:
error[E0433]: failed to resolve: use of undeclared crate or module `glob`
   --> /Users/marco/.cargo/registry/src/index.crates.io-6f17d22bba15001f/git-cliff-core-2.8.0/src/error.rs:113:23
    |
113 |     PatternError(#[from] glob::PatternError),
    |                          ^^^^ use of undeclared crate or module `glob`

For more information about this error, try `rustc --explain E0433`.
error: could not compile `git-cliff-core` (lib) due to 1 previous error

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (no code change)
  • Refactor (refactoring production code)
  • Other

Checklist:

  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have formatted the code with rustfmt.
  • I checked the lints with clippy.
  • I have added tests to cover my changes.
    • I could add a CI check that verifies that git-cliff-core compiles with default features if you want 👍
  • All new and existing tests passed.

@marcoieni marcoieni requested a review from orhun as a code owner February 2, 2025 17:45
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.88%. Comparing base (e61b246) to head (7eda27f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1035      +/-   ##
==========================================
- Coverage   41.93%   41.88%   -0.05%     
==========================================
  Files          21       21              
  Lines        1784     1784              
==========================================
- Hits          748      747       -1     
- Misses       1036     1037       +1     
Flag Coverage Δ
unit-tests 41.88% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@orhun orhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orhun orhun merged commit 0f653bf into orhun:main Feb 2, 2025
66 of 69 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants