Elementor Pro updated support for Pods 2.9+ -- Simple fix #19359
Replies: 2 comments 2 replies
-
|
In addition to this I would also recommend supporting the |
Beta Was this translation helpful? Give feedback.
-
|
Updated my code to match that |
Beta Was this translation helpful? Give feedback.
-
|
Found that a bug report for this (#29454) was closed due to security concerns. I assume allowing at least Currently, image fields are unusable as dynamic tags in Elementor if their file type is set to @sc0ttkclark Moving this to 'Feature Requests' instead of 'Developer Community' in the top-right might help get more traction on this? |
Beta Was this translation helpful? Give feedback.
-
|
@Dinesh-58 moved it to Feature Requests just in case. Might be worth checking with @nicholaszein to get clarification on why allowing any image mimetype that WordPress supports is a security issue. We use Right now that list which WordPress works from by default includes these: // Image formats.
'jpg|jpeg|jpe' => 'image/jpeg',
'gif' => 'image/gif',
'png' => 'image/png',
'bmp' => 'image/bmp',
'tiff|tif' => 'image/tiff',
'webp' => 'image/webp',
'avif' => 'image/avif',
'ico' => 'image/x-icon',
// TODO: Needs improvement. All images with the following mime types seem to have .heic file extension.
'heic' => 'image/heic',
'heif' => 'image/heif',
'heics' => 'image/heic-sequence',
'heifs' => 'image/heif-sequence', |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
This one is easy, I hope your developers can accommodate the simple one-line change to support a new feature in Pods 2.9+ that will be released in a few days.
I am the Lead Developer of the Pods Framework, we have some changes coming in Pods 2.9 that support more fine tuned image file types being selected for our File fields. There needs to be a change in an Elementor Pro file to support this properly.
The file is:
elementor-pro/modules/dynamic-tags/pods/module.phpOn line 99, this:
if ( 'images' !== $field['options']['file_type'] ) {Should be changed to:
if ( ! in_array( $field['options']['file_type'], [ 'images', 'images-any', 'any', 'other' ], true ) ) {We added support for an images-any option in Pods 2.9+ -- it works the same as images, but it allows for any "image/*" mime type supported by WordPress instead of just the four we had support for.
Please pass this along to your developers for a future Elementor Pro maintenance release
from me. It will be important as our shared users begin updating to Pods 2.9 this month.
Beta Was this translation helpful? Give feedback.
All reactions