Align sqlite integration with emacsql 4.0#2503
Merged
dustinfarris merged 3 commits intomainfrom Feb 17, 2025
Merged
Conversation
bf3ef93 to
cce4084
Compare
My editor reformatted some of the identation. Also corrected a docstring for org-roam-refile.
This option is no longer supported in emacsql 4.0 and was throwing linter errors in CI. Ref: magit/emacsql@7a79c2b
org mode timestamps do not support time zones, so returning the machine's local time zone is misleading. Also, org-format-time-string is an obsolete alias of format-time-string. Ref: emacs-straight/org-mode@cc2490a
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a minimum refactor to get CI green again. As a followup, we should fully delegate choosing a sqlite backend to emacsql which now has a function to choose the best available backend. This will reduce a good amount of configuration and documentation complexity.
Also, if we intend to support older versions than emacs 29, we need to figure out how to bootstrap a CI environment that works with the
emacsql-sqlite-modulebackend; and then reenable these versions intest.yml.