Set org-roam-directory to a non-existent path to ensure robust test#2499
Merged
dustinfarris merged 1 commit intoorg-roam:mainfrom Feb 18, 2025
Merged
Conversation
Contributor
manphiz
commented
Jan 11, 2025
- In some rare case, the first expect of org-roam-file-p may return t when running in some environment (e.g. during autopkgtest in Debian).
- Setting org-roam-directory to a non-existent path ensure that the first check is always nil as expected.
Contributor
|
Thanks for this. We need to figure out why CI is failing (for all branches not just this one). |
Contributor
Author
Thanks for taking a look. To be clear, this test failure was in the autopkgtest in a Debian buildd, which is separate from the Github CI. |
Contributor
|
Would you mind rebasing this and see if CI passes now (edit: i fixed the other CI issues — so want to get this PR a green check before merging) |
* In some rare case, the first expect of org-roam-file-p may return t when running in some environment (e.g. during autopkgtest in Debian). * Setting org-roam-directory to a non-existent path ensure that the first check is always nil as expected.
86194d3 to
44c4413
Compare
Contributor
Author
|
Rebased. Also rechecked that the current HEAD still need this patch. Also thanks for fixing Github CI :) |
Contributor
|
Great thank you! ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.