don't complete org-roam nodes in source blocks#2292
Merged
jethrokuan merged 2 commits intoorg-roam:mainfrom Dec 25, 2022
Merged
don't complete org-roam nodes in source blocks#2292jethrokuan merged 2 commits intoorg-roam:mainfrom
jethrokuan merged 2 commits intoorg-roam:mainfrom
Conversation
This fixes the following situation where `org-roam-completion-everywhere = t` and you are working with org-babel blocks in one of your org-roam nodes. ``` ``` Before my nodes would be suggested, but after this change only valid babel headers are suggested as desired. Previously completions from org-roam nodes would be suggested
Contributor
Author
|
@jethrokuan Thanks for fixing the lints. I missed the failure somehow, sorry! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
This fixes the following situation where
org-roam-completion-everywhere = tand you are working with org-babelblocks in one of your org-roam nodes.
Before my nodes would be suggested, but after this change only valid
babel headers are suggested as desired.
Previously completions from org-roam nodes would be suggested