Skip to content

Fix space chars in roam refs#2285

Merged
jethrokuan merged 3 commits intoorg-roam:mainfrom
hwiorn:fix-char-spaces-in-roam-refs
Dec 2, 2022
Merged

Fix space chars in roam refs#2285
jethrokuan merged 3 commits intoorg-roam:mainfrom
hwiorn:fix-char-spaces-in-roam-refs

Conversation

@hwiorn
Copy link
Copy Markdown
Contributor

@hwiorn hwiorn commented Nov 25, 2022

Motivation for this change

Fix #2214

Some URLs and local links have space characters. org-roam can't handle these types of link.

  • Add double quotes if the URL has a space when user is capturing.
  • Update ref cache logic to handle the org-link which has spaces.

@hwiorn hwiorn changed the title Fix char spaces in roam refs Fix space chars in roam refs Nov 25, 2022
@jethrokuan jethrokuan force-pushed the fix-char-spaces-in-roam-refs branch from 56c94f9 to c311119 Compare December 2, 2022 07:52
@jethrokuan jethrokuan merged commit 4e6f934 into org-roam:main Dec 2, 2022
@hwiorn hwiorn deleted the fix-char-spaces-in-roam-refs branch December 6, 2022 05:37
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Org-roam-ref-capture can't handle the spaces within URL.

2 participants