Support multi-line org titles#2264
Merged
jethrokuan merged 3 commits intoorg-roam:mainfrom Dec 2, 2022
Merged
Conversation
jethrokuan
approved these changes
Dec 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
org-mode allows multi-line titles, for example:
This helps with legibility. When exporting, org joins the multiple lines with a space as separator to produce the final title for the exported document.
Until now this functionality does not seem to be supported by org-roam. Only the first line will be used as the title.
I have to admit, I am not a elisp expert but I managed to narrow the problem down to the
org-roam-db--file-title(thanks to its very hepful docstring!).I found out that
(assoc "TITLE" (org-collect-keywords '("title")))returns a list of the title lines. When joined viastring-joinit was consistent with default org behaviour. I also found outstring-joinwas part ofsubr-x(so it might not be available by default?) but I noticed it was already used inorg-roam.el, so this shouldn't bring in new dependencies.However, I can't gurantee that other parts of the code have to be touched to accomodate this change, maybe someone with more experience with the org-roam code base could take a look at this?