Fix org-roam-extract-subtree#2191
Merged
jethrokuan merged 2 commits intoorg-roam:mainfrom May 12, 2022
Merged
Conversation
Calling org-roam-extract-subtree failes with "Symbol’s function definition is void: incf" org-roam.el includes cl-lib. org-roam--h1-count uses a bare incf call, which is undefined. Fix this by using cl-incf.
After fixing incf in 8ec2e59, org-roam-extract-subtree still fails. The error is now: org-roam-db--file-hash: Opening input file: No such file or directory,... The buffer with the newly created content is still unsaved at this time, so save it before calling (org-roam-promote-entire-buffer) Caveat is we now save the buffer two times, before and after promoting it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Calling org-roam-extract-subtree fails with current head.
This PR contains two fixes, making it work again for me: