fix #2083 ID should be added to org-id-locations-file after capture#2086
Merged
jethrokuan merged 2 commits intoorg-roam:masterfrom Feb 8, 2022
Merged
fix #2083 ID should be added to org-id-locations-file after capture#2086jethrokuan merged 2 commits intoorg-roam:masterfrom
jethrokuan merged 2 commits intoorg-roam:masterfrom
Conversation
…apture Currently, Condition 1 below is met. A fix will need to meet Condition 2 in addition. 1. The new Org ID must be available to other functions during the capture process 2. Adding the new Org ID to Org ID file/hash must be done after "Abort" check -- i.e., when the user aborts the capture process, the new ID must not be added to the Org ID file and hash database
Member
|
Thanks @nobiot , I think this fix looks good. Could you:
|
Contributor
Author
|
Of course. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Condition 1 below is met. A fix will need to meet Condition 2 in addition.
The new Org ID must be available to other functions during the capture
process
Adding the new Org ID to Org ID file/hash must be done after "Abort" check
-- i.e., when the user aborts the capture process, the new ID must not be
added to the Org ID file and hash database
Motivation for this change