Merged
Conversation
Org-ref v3 introduced a new citation syntax, and removed some functions that org-roam had previously relied upon (e.g. for extracting keys from multi-citations). This commit introduces support on two fronts: 1. Add `org-roam-org-ref-path-to-keys` which converts a link path to a list of keys. This supports both Org-ref v2 and v3. 2. Adds support for parsing multi-citations in refs.
Member
Author
|
Seems to work. Org-ref v3 citations are showing up in the roam buffer, no "&" hack required. Thanks for sorting this issue. |
Contributor
|
Thank you @jethrokuan. I won’t be able to test this weekend but I trust @jmkard. I don’t use Org-ref myself so i’m not a primary target user. Glad that it’s working for @jmkard. |
This was referenced Nov 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Org-ref v3 introduced a new citation syntax, and removed some functions
that org-roam had previously relied upon (e.g. for extracting keys from
multi-citations).
This commit introduces support on two fronts:
Add
org-roam-org-ref-path-to-keyswhich converts a link path to alist of keys. This supports both Org-ref v2 and v3.
Adds support for parsing multi-citations in refs.
Addresses #1973.