(fix)db: don't consider links in ROAM_REFS as links#1947
Merged
jethrokuan merged 1 commit intomasterfrom Nov 6, 2021
Merged
Conversation
Links within ROAM_REFS are no longer added as links into the database. This prevents self-referencing. Links within other properties are still valid.
nobiot
reviewed
Nov 7, 2021
| (setq link element)) | ||
| ;; Prevent self-referencing links in ROAM_REFS | ||
| ((and (eq type 'node-property) | ||
| (string-equal (org-element-property :key element) "ROAM_REFS")) |
Contributor
There was a problem hiding this comment.
@jethrokuan string-equal is case sensitive (per its docstring).
Are we letting properties to be specified by lower-case?
I use lower-case and this condition returns nil for "roam_refs"...
Member
Author
There was a problem hiding this comment.
Sure, I'll submit another PR for this.
Contributor
There was a problem hiding this comment.
Great. Thank you. There are some other places that use string-equal. I'm hoping that it won't cause cascade of changes...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Links within ROAM_REFS are no longer added as links into the database.
This prevents self-referencing. Links within other properties are still
valid.
Closes #1890