(feat) Separate completion history#1901
Merged
jethrokuan merged 2 commits intoorg-roam:masterfrom Oct 13, 2021
minad:completion-history
Merged
(feat) Separate completion history#1901jethrokuan merged 2 commits intoorg-roam:masterfrom minad:completion-history
jethrokuan merged 2 commits intoorg-roam:masterfrom
minad:completion-history
Conversation
Contributor
minad
commented
Oct 12, 2021
- Use a separate history for completion commands, such that the history only contains relevant candidates
- Minor fix: Do not use completing-read unnecessarily.
Using separate histories has the advantage that the history only contains node names and no other strings from other unrelated minibuffer completions.
Contributor
Author
|
Thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.