Skip to content

Minor fixes around completing-read and more#1893

Merged
jethrokuan merged 5 commits intoorg-roam:masterfrom
minad:fixes
Oct 10, 2021
Merged

Minor fixes around completing-read and more#1893
jethrokuan merged 5 commits intoorg-roam:masterfrom
minad:fixes

Conversation

@minad
Copy link
Copy Markdown
Contributor

@minad minad commented Oct 10, 2021

  • Ensure that sorting is preserved by the completion UI (Vertico/Selectrum/Icomplete/default completion all overwrite sorting by default)
  • Add missing choice nil to org-roam-node-default-sort
  • Ensure that annotation functions are compiled (proper quoting)
  • Removed completion-table-dynamic
  • Hide the graph process buffer (the buffer is usually not of interest)

minad added 5 commits October 10, 2021 07:10
If the nodes are sorted by org-roam we don't want the completion UI to change
the order. In order to disable org-roam sorting set org-roam-node-default-sort
to nil. Then the sorting of the completion UI is used.
Ephemeral buffers are hidden by default in the completion lists,
which is usually desired for background processes.
completion-table-dynamic serves a different purpose. it should only be used if
the candidates are dynamically generated based on the input. This is not the
case for org-roam where we the list of nodes is already available right at the
beginning of the completion. This change should improve performance.
Copy link
Copy Markdown
Member

@jethrokuan jethrokuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jethrokuan jethrokuan merged commit 3a54182 into org-roam:master Oct 10, 2021
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jun 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants