Minor fixes around completing-read and more#1893
Merged
jethrokuan merged 5 commits intoorg-roam:masterfrom Oct 10, 2021
minad:fixes
Merged
Minor fixes around completing-read and more#1893jethrokuan merged 5 commits intoorg-roam:masterfrom minad:fixes
jethrokuan merged 5 commits intoorg-roam:masterfrom
minad:fixes
Conversation
If the nodes are sorted by org-roam we don't want the completion UI to change the order. In order to disable org-roam sorting set org-roam-node-default-sort to nil. Then the sorting of the completion UI is used.
Ephemeral buffers are hidden by default in the completion lists, which is usually desired for background processes.
completion-table-dynamic serves a different purpose. it should only be used if the candidates are dynamically generated based on the input. This is not the case for org-roam where we the list of nodes is already available right at the beginning of the completion. This change should improve performance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.