fix: Do not skip invisible headings when getting node at point.#1798
Merged
jethrokuan merged 1 commit intoorg-roam:masterfrom Aug 21, 2021
Merged
fix: Do not skip invisible headings when getting node at point.#1798jethrokuan merged 1 commit intoorg-roam:masterfrom
jethrokuan merged 1 commit intoorg-roam:masterfrom
Conversation
jethrokuan
requested changes
Aug 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I'm using
org-roam-node-at-pointto fetch the title of the node when building the agenda. Not all my agenda-items are roam-nodes themself and I want to have access to the title of the parent node. However depending on whether the heading tree is visible or collapsed I'm getting different result. Turns out it's just a matter oforg-back-to-heading-or-point-minwhich neededinvisible-okargument.Example of the file that show different results depending on visibility
The result is either "inner" or "org-roam" depending on visibility.