(fix)org-id: gracefully handle absence of org-id-locations-file#1769
Merged
jethrokuan merged 5 commits intomasterfrom Aug 16, 2021
Merged
(fix)org-id: gracefully handle absence of org-id-locations-file#1769jethrokuan merged 5 commits intomasterfrom
org-id-locations-file#1769jethrokuan merged 5 commits intomasterfrom
Conversation
This should be more useful than telling the user to run something like (org-id-update-id-locations (directory-files-recursively ..))
4334f65 to
da6fecd
Compare
org-id normally stores the org-id-locations-file in user-emacs-directory, which should always exist if Emacs is installed. If the path to the location exists, org-id will be able to create the file on its own, however, configurations often change the location of this file to a different one, in which case its path might not be constructed of existing directories (on the file system) and org-id won't be able to laydown this path for the user. This causes org-id to throw unhelpful errors (like in #1734, #1700, \#1688) that don't allow Org-roam to complete capture process or properly finish migration, and possibly add malfunctions at other layers. Ideally this problem should be handled by org-id itself, but for now this will be only patched in Org-roam. Fixes #1700 and fixes #1638.
da6fecd to
ae25ef0
Compare
daviwil
reviewed
Aug 15, 2021
Co-authored-by: David Wilson <david@daviwil.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the source of the errors reported in #1734, #1700, #1688. Ideally this problem should be handled by
org-iditself, but for now this will be only patched in Org-roam.Merging this fixes #1700 and fixes #1638.