Adding :info &key to org-roam-(capture|node-insert)#1741
Merged
jethrokuan merged 1 commit intoorg-roam:masterfrom Aug 9, 2021
Merged
Adding :info &key to org-roam-(capture|node-insert)#1741jethrokuan merged 1 commit intoorg-roam:masterfrom
jethrokuan merged 1 commit intoorg-roam:masterfrom
Conversation
In adding this parameter, the external facing methods expose another point of parameterization for the inner org-roam-capture- method. This is most useful for the org-roam-node-insert method which has a complicated inner logic; By adding the :info &key parameter, we reduce the likelyhood of needing to duplicate that inner logic.
a864df2 to
94e6d02
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In adding this parameter, the external facing methods expose another
point of parameterization for the inner
org-roam-capture-method.This is most useful for the
org-roam-node-insertmethod which has acomplicated inner logic; By adding the
:info&keyparameter, wereduce the likelyhood of needing to duplicate that inner logic.
This relates to work done for #1693.
Closes #1740