When capturing a file, check if it exists on disk too#1713
Merged
jethrokuan merged 2 commits intoorg-roam:masterfrom Jul 30, 2021
Merged
When capturing a file, check if it exists on disk too#1713jethrokuan merged 2 commits intoorg-roam:masterfrom
jethrokuan merged 2 commits intoorg-roam:masterfrom
Conversation
We now check for either an unsaved buffer visiting the file path, or the unvisited file on disk.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now check for either an unsaved buffer visiting the file path, or
the unvisited file on disk.
Motivation for this change
#1707 replaced checking if a file exists on disk with checking if a buffer is visiting it.
This PR combines both tests, so it is regarded as existing if either it is being visited in a buffer but is still unsaved, or is unvisited on disk.
See #1707 (comment)