(fix): only update relative path of file links#1226
Merged
jethrokuan merged 2 commits intoorg-roam:masterfrom Nov 3, 2020
Merged
(fix): only update relative path of file links#1226jethrokuan merged 2 commits intoorg-roam:masterfrom
jethrokuan merged 2 commits intoorg-roam:masterfrom
Conversation
d12frosted
reviewed
Oct 30, 2020
Contributor
d12frosted
left a comment
There was a problem hiding this comment.
this looks good! I also run into this issue, thanks for taking your time to send a PR :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Addresses #1224 by only updating a relative link after we check that it is a file link.