Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.41%. Comparing base (5c3a2ee) to head (d88a154).
⚠️ Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main     #329      +/-   ##
==========================================
+ Coverage   69.41%   69.41%   +0.01%     
==========================================
  Files          33       33              
  Lines        4053     4051       -2     
==========================================
- Hits         2813     2812       -1     
+ Misses       1240     1239       -1     

Would you mind rebasing this on the latest main? I merged PR 1/4 with slight changes.

@hassila done

Do you have an example that generated the output from the screenshots? Would be good to understand the configuration used for the test.

@hassila not 100% sure, but try this:

Benchmark.defaultConfiguration.units = [<metric>: .kilo]

and make sure the output should not be in kilos (but observe that it will be, without this PR).

I just noticed you asked for an example not just the configuration, I'm already off the desk though so I'll grab that tomorow.

This is what i think was the benchmark when the issue here happened (although i think even the new benchmarks would have this issue):

https://github.com/MahdiBM/swift-dns/blob/202d4734bf158887a5691c2871bfeb8ecca7c73c/Benchmarks/Name/Name.swift#L160

I think you can just compare 2 strings instead of 2 Names, since that's a custom type.

Thanks, I've reproduced this and verified the fix with:

swift package --allow-writing-to-package-directory benchmark thresholds update --target Basic --filter "Equality_Check_Identical_Throughput"
swift package benchmark thresholds check --target Basic --filter "Equality_Check_Identical_Throughput"

(just a note for the future)

Thanks!