Skip to content

Strath/next gen plus#56

Merged
kien6034 merged 30 commits intoorbitorg:sdk53-ibcv2from
StrathCole:strath/next-gen-plus
Oct 5, 2025
Merged

Strath/next gen plus#56
kien6034 merged 30 commits intoorbitorg:sdk53-ibcv2from
StrathCole:strath/next-gen-plus

Conversation

@StrathCole
Copy link
Copy Markdown

No description provided.

@kien6034
Copy link
Copy Markdown

kien6034 commented Oct 4, 2025

LFG

interfaceRegistry, err := types.NewInterfaceRegistryWithOptions(types.InterfaceRegistryOptions{
ProtoFiles: proto.HybridResolver,
SigningOptions: signing.Options{
AddressCodec: addresscodec.NewBech32Codec(core.Bech32PrefixAccAddr),

Check warning

Code scanning / CodeQL

Directly using the bech32 constants Warning

Directly using the bech32 constants instead of the configuration values
ProtoFiles: proto.HybridResolver,
SigningOptions: signing.Options{
AddressCodec: addresscodec.NewBech32Codec(core.Bech32PrefixAccAddr),
ValidatorAddressCodec: addresscodec.NewBech32Codec(core.Bech32PrefixValAddr),

Check warning

Code scanning / CodeQL

Directly using the bech32 constants Warning

Directly using the bech32 constants instead of the configuration values
Comment on lines +158 to +162
for _, opt := range modOpts {
if opt != nil {
opt.Tx = nil
}
}

Check warning

Code scanning / CodeQL

Iteration over map Warning

Iteration over map may be a possible source of non-determinism
ms := store.NewCommitMultiStore(db)
ctx := sdk.NewContext(ms, tmproto.Header{Time: time.Now().UTC()}, false, log.NewNopLogger())
ms := store.NewCommitMultiStore(db, sdklog.NewNopLogger(), storemetrics.NewNoOpMetrics())
ctx := sdk.NewContext(ms, tmproto.Header{Time: time.Now().UTC()}, false, sdklog.NewNopLogger())

Check warning

Code scanning / CodeQL

Calling the system time Warning test

Calling the system time may be a possible source of non-determinism
keyStaking := sdk.NewKVStoreKey(stakingtypes.StoreKey)
keyDistr := sdk.NewKVStoreKey(distrtypes.StoreKey)
// Ensure Terra bech32 prefixes are set for address codecs used by keepers
sdk.GetConfig().SetBech32PrefixForAccount(core.Bech32PrefixAccAddr, core.Bech32PrefixAccPub)

Check warning

Code scanning / CodeQL

Directly using the bech32 constants Warning test

Directly using the bech32 constants instead of the configuration values
keyCapability := sdk.NewKVStoreKey(capabilitytypes.StoreKey)
// keyUpgrade := sdk.NewKVStoreKey(upgradetypes.StoreKey)
memKeyCapability := sdk.NewMemoryStoreKeys(capabilitytypes.MemStoreKey)
sdk.GetConfig().SetBech32PrefixForValidator(core.Bech32PrefixValAddr, core.Bech32PrefixValPub)

Check warning

Code scanning / CodeQL

Directly using the bech32 constants Warning test

Directly using the bech32 constants instead of the configuration values
// keyUpgrade := sdk.NewKVStoreKey(upgradetypes.StoreKey)
memKeyCapability := sdk.NewMemoryStoreKeys(capabilitytypes.MemStoreKey)
sdk.GetConfig().SetBech32PrefixForValidator(core.Bech32PrefixValAddr, core.Bech32PrefixValPub)
sdk.GetConfig().SetBech32PrefixForConsensusNode(core.Bech32PrefixConsAddr, core.Bech32PrefixConsPub)

Check warning

Code scanning / CodeQL

Directly using the bech32 constants Warning test

Directly using the bech32 constants instead of the configuration values
// keyUpgrade := sdk.NewKVStoreKey(upgradetypes.StoreKey)
memKeyCapability := sdk.NewMemoryStoreKeys(capabilitytypes.MemStoreKey)
sdk.GetConfig().SetBech32PrefixForValidator(core.Bech32PrefixValAddr, core.Bech32PrefixValPub)
sdk.GetConfig().SetBech32PrefixForConsensusNode(core.Bech32PrefixConsAddr, core.Bech32PrefixConsPub)

Check warning

Code scanning / CodeQL

Directly using the bech32 constants Warning test

Directly using the bech32 constants instead of the configuration values
ms := store.NewCommitMultiStore(db)
ctx := sdk.NewContext(ms, tmproto.Header{Time: time.Now().UTC()}, false, log.NewNopLogger())
ms := store.NewCommitMultiStore(db, sdklog.NewNopLogger(), storemetrics.NewNoOpMetrics())
ctx := sdk.NewContext(ms, tmproto.Header{Time: time.Now().UTC()}, false, sdklog.NewNopLogger())

Check warning

Code scanning / CodeQL

Calling the system time Warning test

Calling the system time may be a possible source of non-determinism
// EndBlock implements the SDK v0.50 end blocker signature.
func (am AppModule) EndBlock(ctx context.Context) ([]abci.ValidatorUpdate, error) {
sdkCtx := sdk.UnwrapSDKContext(ctx)
EndBlocker(sdkCtx, am.keeper)

Check warning

Code scanning / CodeQL

Panic in BeginBock or EndBlock consensus methods Warning

path flow from Begin/EndBlock to a panic call
@kien6034
Copy link
Copy Markdown

kien6034 commented Oct 5, 2025

Lets merge it and then continuing working on this @TropicalDog17 @hoank101

@kien6034 kien6034 merged commit 06483ff into orbitorg:sdk53-ibcv2 Oct 5, 2025
20 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants