This repository was archived by the owner on Sep 30, 2023. It is now read-only.
feat: allow non json data types to be used.#19
Merged
aphelionz merged 2 commits intoorbitdb-archive:masterfrom May 4, 2020
Merged
feat: allow non json data types to be used.#19aphelionz merged 2 commits intoorbitdb-archive:masterfrom
aphelionz merged 2 commits intoorbitdb-archive:masterfrom
Conversation
aphelionz
approved these changes
May 3, 2020
Contributor
aphelionz
left a comment
There was a problem hiding this comment.
Overall looks good! How do the orbit-db tests fare against this?
aphelionz
suggested changes
May 3, 2020
Contributor
aphelionz
left a comment
There was a problem hiding this comment.
Sorry - Approved by accident. Approval pending conversations, squash, docs...
Also would you be willing to throw a test or two in there? I can hook up CI on this repo if so
aphelionz
approved these changes
May 3, 2020
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows other data serializations as specified by higher level code to be used. No longer forces json serialization. Support is backwards compatible is detected as object for publish or detected as JSON for receiving end.