Merged
Conversation
|
I like the quality of life improvement. I really liked both of the options in #197. I can't help but notice that you didn't go with either of those. Is there a reason for that? I think the reason I prefer the original API options is that I preferred the generic parameter better than passing the actual class. |
Contributor
Author
|
@jadar since the extension function takes 3 type parameters (state, side effect, type to "cast"), you'd have to write I would have also preferred a single type parameter 💯 This is as close to That said, I'll keep this in mind and keep trying to simplify |
This was referenced Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses: #191
This is not going to turn Orbit into a state machine, but it adds some quality-of-life improvements to working with a sealed class state.
The code in the block is only executed if and while the state is of a given type and matches the predicate. Once either of those conditions becomes no longer true after a state update, the block is cancelled.