Generating OrbbecSDKConfigVersion.cmake file#107
Closed
matlabbe wants to merge 2 commits intoorbbec:mainfrom
Closed
Generating OrbbecSDKConfigVersion.cmake file#107matlabbe wants to merge 2 commits intoorbbec:mainfrom
matlabbe wants to merge 2 commits intoorbbec:mainfrom
Conversation
6 tasks
Contributor
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The PR adds cmake code to generate a standard
OrbbecSDKConfigVersion.cmake, useful when requesting a specific package version from downstream projects including the library with cmake:find_package(OrbbecSDK 2 REQUIRED). Because the OrbbecSDK v1 library shares exactly the same package name, the only way downstream to differentiate the versions with cmake is by using the standard approach as above.Current issue that this PR solves
If in a downstream project we do:
We may end up with either OrbbecSDK v1 or OrbbecSDK v2 target, if both are installed at the same time.
If we do instead:
we would get error like this (even if OrbbecSDK v2 is installed):
Results with this PR
With:
we then get: