Skip to content

perf: use new built-in methods introduced before go 1.22#726

Merged
Wwwsylvia merged 4 commits into
oras-project:mainfrom
shizhMSFT:upgrade_perf
Mar 20, 2024
Merged

perf: use new built-in methods introduced before go 1.22#726
Wwwsylvia merged 4 commits into
oras-project:mainfrom
shizhMSFT:upgrade_perf

Conversation

@shizhMSFT

@shizhMSFT shizhMSFT commented Mar 19, 2024

Copy link
Copy Markdown
Contributor

Changes:

  • chore: use built-in slices
  • perf: use built-in map clone
  • chore: use built-in map copy
  • perf: use slices.Sort instead of sort.Strings

Resolves: #713

@codecov

codecov Bot commented Mar 19, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.62%. Comparing base (8d139f0) to head (a1d93c0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #726      +/-   ##
==========================================
- Coverage   75.62%   75.62%   -0.01%     
==========================================
  Files          64       63       -1     
  Lines        5994     5981      -13     
==========================================
- Hits         4533     4523      -10     
+ Misses       1078     1076       -2     
+ Partials      383      382       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
Signed-off-by: Shiwei Zhang <shizh@microsoft.com>
@shizhMSFT shizhMSFT force-pushed the upgrade_perf branch 2 times, most recently from 7cb6519 to a1d93c0 Compare March 19, 2024 12:37
@shizhMSFT shizhMSFT changed the title chore: use new built-in methods introduced before go 1.22 perf: use new built-in methods introduced before go 1.22 Mar 19, 2024
@wangxiaoxuan273

Copy link
Copy Markdown
Contributor

LGTM although IANAM

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 4503c31 into oras-project:main Mar 20, 2024
@shizhMSFT shizhMSFT deleted the upgrade_perf branch March 20, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Shift Go Support Window to [1.21, 1.22]

3 participants