Skip to content

feat: add MountFrom and OnMounted to CopyGraphOptions#665

Merged
shizhMSFT merged 1 commit into
oras-project:mainfrom
ktarplee:580-mount-copy-refactor
Jan 10, 2024
Merged

feat: add MountFrom and OnMounted to CopyGraphOptions#665
shizhMSFT merged 1 commit into
oras-project:mainfrom
ktarplee:580-mount-copy-refactor

Conversation

@ktarplee

@ktarplee ktarplee commented Jan 3, 2024

Copy link
Copy Markdown
Contributor

Adds MountFrom and OnMounted to CopyGraphOptions.
Allows for trying to mount from multiple repositories.

Closes #580

I think this is a better approach than my other PR #632

@ktarplee ktarplee changed the title feat: added blob mounting support for oras Copy functions feat: add MountFrom and OnMounted to CopyGraphOptions Jan 3, 2024
@ktarplee ktarplee force-pushed the 580-mount-copy-refactor branch from 2d6b4c5 to 75b9a9f Compare January 3, 2024 02:21
@codecov

codecov Bot commented Jan 3, 2024

Copy link
Copy Markdown

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (d1becd5) 75.46% compared to head (c971de8) 75.57%.

Files Patch % Lines
copy.go 83.01% 6 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #665      +/-   ##
==========================================
+ Coverage   75.46%   75.57%   +0.11%     
==========================================
  Files          59       59              
  Lines        5640     5692      +52     
==========================================
+ Hits         4256     4302      +46     
- Misses       1019     1023       +4     
- Partials      365      367       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions. I think this design is indeed a better approach than #632.

Comment thread copy.go Outdated
Comment thread copy.go Outdated
Comment thread copy.go Outdated
Comment thread copy.go Outdated
Comment thread copy.go Outdated
@shizhMSFT

Copy link
Copy Markdown
Contributor

@ktarplee Meanwhile, could you increase the code coverage so that the check can pass?

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread copy.go Outdated
Comment thread copy.go Outdated
Adds MountFrom and OnMounted to CopyGraphOptions.
Allows for trying to mount from multiple repositories.

Signed-off-by: Kyle M. Tarplee <kmtarplee@ieee.org>
@ktarplee ktarplee force-pushed the 580-mount-copy-refactor branch from ecccb8b to c971de8 Compare January 10, 2024 00:47
@ktarplee

Copy link
Copy Markdown
Contributor Author

@Wwwsylvia @shizhMSFT I pushed my changes. Sorry about the delay.

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support cross-repository mounting in Copy

3 participants