Skip to content

feat(registry/remote): implement Mount#500

Merged
shizhMSFT merged 1 commit into
oras-project:mainfrom
rogpeppe-contrib:001-mount
May 8, 2023
Merged

feat(registry/remote): implement Mount#500
shizhMSFT merged 1 commit into
oras-project:mainfrom
rogpeppe-contrib:001-mount

Conversation

@rogpeppe

@rogpeppe rogpeppe commented May 5, 2023

Copy link
Copy Markdown
Contributor

This adds support for "mounting" (a.k.a. copy by reference) a blob from one repository to another in the same registry.

As documented in https://docs.docker.com/registry/spec/api/#blob and https://github.com/opencontainers/distribution-spec/blob/main/spec.md#mounting-a-blob-from-another-repository.

I've also manually verified that this works against at least one real registry implementation (zot).

Fixes #337

This implements blob-mount functionality as described

@shizhMSFT shizhMSFT changed the title registry/remote: implement Mount feat(registry/remote): implement Mount May 5, 2023

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you sign-off your commit to pass the DCO check?

Comment thread registry/remote/repository.go Outdated
Comment thread registry/remote/repository.go Outdated
Comment thread registry/remote/repository.go Outdated
Comment thread registry/remote/url.go Outdated
Comment thread registry/remote/url.go Outdated
Comment thread registry/remote/url.go Outdated
Comment thread registry/remote/repository.go
Comment thread registry/remote/repository.go Outdated
@sajayantony

sajayantony commented May 6, 2023

Copy link
Copy Markdown
Contributor

Pinging @Wwwsylvia who I think has a lot of history with mount :). Correct me if I'm wrong Sylvia.

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT

Copy link
Copy Markdown
Contributor

Pinging @Wwwsylvia for reviewing this PR.

Comment thread registry/remote/repository.go Outdated
Comment thread registry/remote/repository.go Outdated
Comment thread registry/remote/repository.go
@Wwwsylvia

Copy link
Copy Markdown
Member

@sajayantony You still remember my history with mount😂

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread registry/remote/repository.go Outdated
This adds support for "mounting" (a.k.a. copy by reference) a blob
from one repository to another in the same registry.

As documented in https://docs.docker.com/registry/spec/api/#blob
and https://github.com/opencontainers/distribution-spec/blob/main/spec.md#mounting-a-blob-from-another-repository.

I've also manually verified that this works against at least one real registry implementation (zot).

Fixes oras-project#337

This implements blob-mount functionality as described

Signed-off-by: Roger Peppe <rogpeppe@gmail.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit c083b73 into oras-project:main May 8, 2023
@Wwwsylvia Wwwsylvia mentioned this pull request May 24, 2023
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support blob mount across repositories

4 participants