Skip to content
This repository was archived by the owner on Apr 7, 2024. It is now read-only.

deprecate: deprecate all existing APIs#96

Merged
Wwwsylvia merged 14 commits into
oras-project:mainfrom
Wwwsylvia:depre
Sep 25, 2023
Merged

deprecate: deprecate all existing APIs#96
Wwwsylvia merged 14 commits into
oras-project:mainfrom
Wwwsylvia:depre

Conversation

@Wwwsylvia

Copy link
Copy Markdown
Member
  1. Deprecate all existing APIs as they have been moved to oras-go
  2. Update README accordingly

Resolve: #95

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@codecov-commenter

codecov-commenter commented Sep 22, 2023

Copy link
Copy Markdown

Codecov Report

Merging #96 (aafd9c7) into main (8b76a43) will decrease coverage by 12.59%.
The diff coverage is 64.70%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##             main      #96       +/-   ##
===========================================
- Coverage   76.86%   64.28%   -12.59%     
===========================================
  Files           8        6        -2     
  Lines         428       28      -400     
===========================================
- Hits          329       18      -311     
+ Misses         77       10       -67     
+ Partials       22        0       -22     
Files Changed Coverage Δ
native_store.go 0.00% <0.00%> (-83.34%) ⬇️
trace/trace.go 0.00% <0.00%> (ø)
registry.go 80.00% <80.00%> (-1.25%) ⬇️
file_store.go 100.00% <100.00%> (ø)
memory_store.go 100.00% <100.00%> (ø)
store.go 100.00% <100.00%> (+19.04%) ⬆️

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Comment thread memory_store.go Outdated
Comment thread README.md Outdated
Comment thread file_store.go Outdated
Comment thread memory_store.go Outdated
Comment thread file_store.go Outdated
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Comment thread file_store.go Outdated
Comment thread trace/trace.go Outdated
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Comment thread file_store.go Outdated
Comment thread memory_store.go
Comment thread native_store.go
Comment thread registry.go Outdated
Comment thread store.go
Comment thread trace/trace.go Outdated
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 9299052 into oras-project:main Sep 25, 2023
@Wwwsylvia Wwwsylvia deleted the depre branch September 25, 2023 06:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deprecating APIs

3 participants