Skip to content
This repository was archived by the owner on Apr 7, 2024. It is now read-only.

docs: add an example for trace#86

Merged
Wwwsylvia merged 2 commits into
oras-project:mainfrom
wangxiaoxuan273:trace-example
Jul 19, 2023
Merged

docs: add an example for trace#86
Wwwsylvia merged 2 commits into
oras-project:mainfrom
wangxiaoxuan273:trace-example

Conversation

@wangxiaoxuan273

Copy link
Copy Markdown
Collaborator

Resolves #85

@codecov-commenter

codecov-commenter commented Jul 18, 2023

Copy link
Copy Markdown

Codecov Report

Merging #86 (f210ca8) into main (2afb422) will decrease coverage by 6.38%.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main      #86      +/-   ##
==========================================
- Coverage   82.46%   76.08%   -6.38%     
==========================================
  Files           6        7       +1     
  Lines         382      414      +32     
==========================================
  Hits          315      315              
- Misses         45       77      +32     
  Partials       22       22              

see 1 file with indirect coverage changes

Comment thread example_test.go Outdated
Comment thread example_test.go Outdated
Comment thread example_test.go Outdated
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
Comment thread trace/example_test.go Outdated
panic(err)
}

// define traceHooks and add it to the context. The 'action' argument refers

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit:

Suggested change
// define traceHooks and add it to the context. The 'action' argument refers
// Define ExecutableTrace and add it to the context. The 'action' argument refers

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed accordingly.

Comment thread trace/example_test.go
Comment thread trace/example_test.go
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 5e38e75 into oras-project:main Jul 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add examples for package trace

3 participants