Skip to content
This repository was archived by the owner on Apr 7, 2024. It is now read-only.

refactor!: rename DetectDefaultCredsStore to DetectDefaultNativeStore#75

Merged
Wwwsylvia merged 2 commits into
oras-project:mainfrom
Wwwsylvia:rename
Jun 9, 2023
Merged

refactor!: rename DetectDefaultCredsStore to DetectDefaultNativeStore#75
Wwwsylvia merged 2 commits into
oras-project:mainfrom
Wwwsylvia:rename

Conversation

@Wwwsylvia

@Wwwsylvia Wwwsylvia commented Jun 9, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

BREAKING CHANGE: StoreOptions.DetectDefaultCredsStore is renamed to StoreOptions.DetectDefaultNativeStore

Wwwsylvia added 2 commits June 9, 2023 16:57
@Wwwsylvia
rename DetectDefaultCredsStore to DetectDefaultNativeStore
cc70561 
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
@Wwwsylvia
improve test
cf9c8dd 
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
shizhMSFT
shizhMSFT approved these changes Jun 9, 2023
View reviewed changes

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit bf5244c into oras-project:main Jun 9, 2023
@Wwwsylvia Wwwsylvia deleted the rename branch June 9, 2023 09:29
@wangxiaoxuan273 wangxiaoxuan273 mentioned this pull request Jun 19, 2023
Closed
3 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@TerryHowe TerryHowe Awaiting requested review from TerryHowe TerryHowe is a code owner

1 more reviewer

@shizhMSFT shizhMSFT shizhMSFT approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Wwwsylvia @shizhMSFT