This repository was archived by the owner on Apr 7, 2024. It is now read-only.
feat!: add NewDefaultNativeStore and DynamicStore.IsAuthConfigured#73
Merged
Conversation
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #73 +/- ##
==========================================
+ Coverage 82.41% 82.73% +0.31%
==========================================
Files 6 6
Lines 381 388 +7
==========================================
+ Hits 314 321 +7
Misses 45 45
Partials 22 22
|
Wwwsylvia
commented
Jun 8, 2023
Member
Author
|
One usage of this change: notaryproject/notation#712 |
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
NewDefaultNativeStore and DynamicStore.IsAuthConfigured
NewDefaultNativeStore and DynamicStore.IsAuthConfiguredNewDefaultNativeStore and DynamicStore.IsAuthConfigured
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Features:
NewDefaultNativeStore()DynamicStoreandDynamicStore.IsAuthConfiguredStoreOptions.DetectDefaultCredsStoreBREAKING CHANGE: When there is no authentication configured in the config file,
DynamicStoreno longer detects and sets the platform-default docker credentials helper by default.Fixes: #71