This repository was archived by the owner on Apr 7, 2024. It is now read-only.
docs: add examples for NewStoreFromDocker and NewStoreWithFallbacks#55
Merged
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #55 +/- ##
=======================================
Coverage 81.13% 81.13%
=======================================
Files 6 6
Lines 371 371
=======================================
Hits 301 301
Misses 48 48
Partials 22 22
|
Wwwsylvia
suggested changes
Apr 27, 2023
shizhMSFT
reviewed
Apr 27, 2023
| ) | ||
|
|
||
| func ExampleNewStoreFromDocker() { | ||
| ds, err := credentials.NewStoreFromDocker(credentials.StoreOptions{AllowPlaintextPut: true}) |
Contributor
There was a problem hiding this comment.
Let's format the code in standard go style.
Suggested change
| ds, err := credentials.NewStoreFromDocker(credentials.StoreOptions{AllowPlaintextPut: true}) | |
| ds, err := credentials.NewStoreFromDocker(credentials.StoreOptions{ | |
| AllowPlaintextPut: true, | |
| }) |
Contributor
There was a problem hiding this comment.
same for the other example
Comment on lines
+31
to
+34
| err = ds.Put(context.Background(), "localhost:8080", | ||
| auth.Credential{ | ||
| Username: "username-example", | ||
| Password: "password-example"}) |
Contributor
There was a problem hiding this comment.
Suggested change
| err = ds.Put(context.Background(), "localhost:8080", | |
| auth.Credential{ | |
| Username: "username-example", | |
| Password: "password-example"}) | |
| err = ds.Put(context.Background(), "localhost:8080", auth.Credential{ | |
| Username: "username-example", | |
| Password: "password-example", | |
| }) |
Contributor
There was a problem hiding this comment.
same for the other example
Comment on lines
+70
to
+178
| // get credentials from the store | ||
| cred, err := sf.Get(context.Background(), "localhost:8080") | ||
| if err != nil { | ||
| panic(err) | ||
| } | ||
| fmt.Println(cred) |
Contributor
There was a problem hiding this comment.
Getting from fallback store is not demonstrated.
Collaborator
Author
There was a problem hiding this comment.
Changed the function name to ExampleNewStoreWithFallbacks_configAsPrimaryStoreDockerAsFallback to demonstrate the scenario.
shizhMSFT
reviewed
Apr 27, 2023
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #49