Skip to content
This repository was archived by the owner on Apr 7, 2024. It is now read-only.

docs: add examples for three store functions#54

Merged
shizhMSFT merged 1 commit into
oras-project:mainfrom
wangxiaoxuan273:basic-examples
Apr 27, 2023
Merged

docs: add examples for three store functions#54
shizhMSFT merged 1 commit into
oras-project:mainfrom
wangxiaoxuan273:basic-examples

Conversation

@wangxiaoxuan273

Copy link
Copy Markdown
Collaborator

Part of issue #49

@wangxiaoxuan273 wangxiaoxuan273 changed the title ci test, please don't review ... yet test: add examples for three store functions Apr 26, 2023
Comment thread example_test.go
Comment thread example_test.go Outdated
Comment thread example_test.go Outdated
Comment thread example_test.go
Comment thread example_test.go Outdated
Comment thread store.go
Comment thread example_test.go Outdated
@Wwwsylvia

Wwwsylvia commented Apr 26, 2023

Copy link
Copy Markdown
Member

I think the PR title should start with docs:.

@wangxiaoxuan273 wangxiaoxuan273 changed the title test: add examples for three store functions docs: add examples for three store functions Apr 27, 2023
@codecov-commenter

codecov-commenter commented Apr 27, 2023

Copy link
Copy Markdown

Codecov Report

Merging #54 (b49d76c) into main (d610c11) will not change coverage.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main      #54   +/-   ##
=======================================
  Coverage   81.13%   81.13%           
=======================================
  Files           6        6           
  Lines         371      371           
=======================================
  Hits          301      301           
  Misses         48       48           
  Partials       22       22           
Impacted Files Coverage Δ
native_store.go 76.92% <ø> (ø)
store.go 76.82% <ø> (ø)

Comment thread example_test.go Outdated
Comment thread example_test.go

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread example_test.go Outdated
Comment on lines +28 to +31
err := ns.Put(context.Background(), "localhost:8080",
auth.Credential{
Username: "username-example",
Password: "password-example"})

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's format the code.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatted.

Comment thread example_test.go Outdated
Comment thread example_test.go Outdated
Comment thread example_test.go Outdated
Signed-off-by: Xiaoxuan Wang <wangxiaoxuan119@gmail.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit f738d10 into oras-project:main Apr 27, 2023
@wangxiaoxuan273 wangxiaoxuan273 deleted the basic-examples branch April 27, 2023 12:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants