Skip to content
This repository was archived by the owner on Apr 7, 2024. It is now read-only.

feat: support creating store from the default Docker config file#52

Merged
Wwwsylvia merged 4 commits into
oras-project:mainfrom
Wwwsylvia:docker_store
Apr 24, 2023
Merged

feat: support creating store from the default Docker config file#52
Wwwsylvia merged 4 commits into
oras-project:mainfrom
Wwwsylvia:docker_store

Conversation

@Wwwsylvia

Copy link
Copy Markdown
Member

Resolves: #34

Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
@codecov-commenter

codecov-commenter commented Apr 24, 2023

Copy link
Copy Markdown

Codecov Report

Merging #52 (d0224a5) into main (5458be0) will decrease coverage by 0.53%.
The diff coverage is 47.05%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main      #52      +/-   ##
==========================================
- Coverage   58.47%   57.95%   -0.53%     
==========================================
  Files           6        6              
  Lines         354      371      +17     
==========================================
+ Hits          207      215       +8     
- Misses        125      133       +8     
- Partials       22       23       +1     
Impacted Files Coverage Δ
file_store.go 100.00% <ø> (ø)
internal/config/config.go 32.51% <ø> (ø)
store.go 73.17% <47.05%> (-6.83%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
@Wwwsylvia Wwwsylvia changed the title Support creating store from the default Docker config file feat: Support creating store from the default Docker config file Apr 24, 2023

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia changed the title feat: Support creating store from the default Docker config file feat: support creating store from the default Docker config file Apr 24, 2023
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit ba6b33c into oras-project:main Apr 24, 2023
@Wwwsylvia Wwwsylvia deleted the docker_store branch April 24, 2023 07:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support creating store from the default Docker config file

3 participants