Skip to content
This repository was archived by the owner on Apr 7, 2024. It is now read-only.

feat: Support creating store from a config file#47

Merged
Wwwsylvia merged 34 commits into
oras-project:mainfrom
Wwwsylvia:newstore
Apr 21, 2023
Merged

feat: Support creating store from a config file#47
Wwwsylvia merged 34 commits into
oras-project:mainfrom
Wwwsylvia:newstore

Conversation

@Wwwsylvia

Copy link
Copy Markdown
Member

Resolves: #30

@codecov-commenter

codecov-commenter commented Apr 19, 2023

Copy link
Copy Markdown

Codecov Report

Merging #47 (933f90d) into main (8f27cf8) will decrease coverage by 19.45%.
The diff coverage is 48.29%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##             main      #47       +/-   ##
===========================================
- Coverage   77.91%   58.47%   -19.45%     
===========================================
  Files           4        6        +2     
  Lines         240      354      +114     
===========================================
+ Hits          187      207       +20     
- Misses         39      125       +86     
- Partials       14       22        +8     
Impacted Files Coverage Δ
internal/config/config.go 32.51% <32.51%> (ø)
native_store.go 76.92% <50.00%> (+7.22%) ⬆️
native_store_linux.go 80.00% <80.00%> (ø)
store.go 80.00% <84.09%> (+8.57%) ⬆️
file_store.go 100.00% <100.00%> (+17.42%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Comment thread internal/config/config.go Outdated
Comment thread dynamic_store.go Outdated
Comment thread default_native_helper_darwin.go
Comment thread default_native_helper_unsupported.go Outdated
Comment thread internal/config/config.go Outdated
Comment thread internal/config/config.go
Comment thread internal/config/config.go Outdated
Comment thread internal/config/config.go
Comment thread file_store.go Outdated
Wwwsylvia and others added 22 commits April 20, 2023 19:07
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <Lixia.Lei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <Lixia.Lei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Comment thread store.go Outdated
Comment thread store.go
Comment thread store.go
Comment thread internal/config/config.go
Comment thread internal/config/config.go
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>
Comment thread internal/config/config.go Outdated
Comment thread internal/config/config.go Outdated
Comment thread internal/config/config.go Outdated
Comment thread store.go Outdated
Signed-off-by: Sylvia Lei <lixlei@microsoft.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia Wwwsylvia merged commit 5458be0 into oras-project:main Apr 21, 2023
@Wwwsylvia Wwwsylvia deleted the newstore branch April 21, 2023 12:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support creating store from a config file

5 participants