This repository was archived by the owner on Apr 7, 2024. It is now read-only.
feat: support logout#44
Merged
Merged
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #44 +/- ##
==========================================
- Coverage 72.30% 70.42% -1.89%
==========================================
Files 2 2
Lines 65 71 +6
==========================================
+ Hits 47 50 +3
- Misses 15 17 +2
- Partials 3 4 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Wwwsylvia
reviewed
Apr 7, 2023
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
shizhMSFT
suggested changes
Apr 13, 2023
| func Logout(ctx context.Context, store Store, registryName string) error { | ||
| registryName = mapHostname(registryName) | ||
| if err := store.Delete(ctx, registryName); err != nil { | ||
| return fmt.Errorf("unable to logout of the registry %s: %w", registryName, err) |
Contributor
There was a problem hiding this comment.
This error message is not consistent with line 53.
BTW, for line 49, it should not be "unable to login to the registry" but "unable to ping the registry".
Collaborator
Author
There was a problem hiding this comment.
changed accordingly.
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #32