Skip to content
This repository was archived by the owner on Apr 7, 2024. It is now read-only.

feat: implement native store#41

Merged
TerryHowe merged 4 commits into
oras-project:mainfrom
wangxiaoxuan273:native-store
Apr 4, 2023
Merged

feat: implement native store#41
TerryHowe merged 4 commits into
oras-project:mainfrom
wangxiaoxuan273:native-store

Conversation

@wangxiaoxuan273

Copy link
Copy Markdown
Collaborator

Resolves #29

@codecov-commenter

codecov-commenter commented Apr 3, 2023

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (main@0ad40e9). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage        ?   69.69%           
=======================================
  Files           ?        1           
  Lines           ?       33           
  Branches        ?        0           
=======================================
  Hits            ?       23           
  Misses          ?        9           
  Partials        ?        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TerryHowe TerryHowe merged commit aead42c into oras-project:main Apr 4, 2023
@wangxiaoxuan273

Copy link
Copy Markdown
Collaborator Author

Tested with docker-credential-helpers and pass (Linux's native store) on Ubuntu. Need to further test it on MacOS and Windows.

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wangxiaoxuan273 wangxiaoxuan273 deleted the native-store branch April 6, 2023 05:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement Native Store

5 participants