Skip to content

fix(tests): fix packer test that failed on Windows#1774

Merged
Wwwsylvia merged 1 commit into
oras-project:mainfrom
Wwwsylvia:fix_packer_test
Jul 7, 2025
Merged

fix(tests): fix packer test that failed on Windows#1774
Wwwsylvia merged 1 commit into
oras-project:mainfrom
Wwwsylvia:fix_packer_test

Conversation

@Wwwsylvia

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Fix the test TestPacker_decodeJSON which fails on Windows with the following message:

--- FAIL: TestPacker_decodeJSON (0.00s)
packer_test.go:173: unexpected error: open nonexistent-file.json: The system cannot find the file specified.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@codecov

codecov Bot commented Jul 4, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.39%. Comparing base (4264b96) to head (e869d8a).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1774      +/-   ##
==========================================
+ Coverage   85.36%   85.39%   +0.03%     
==========================================
  Files         137      137              
  Lines        5951     5951              
==========================================
+ Hits         5080     5082       +2     
+ Misses        620      618       -2     
  Partials      251      251              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Wwwsylvia Wwwsylvia merged commit e913ef1 into oras-project:main Jul 7, 2025
8 checks passed
@Wwwsylvia Wwwsylvia deleted the fix_packer_test branch July 7, 2025 02:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants