refactor: use handlers for oras blob push command#1618
Merged
Conversation
added 4 commits
December 5, 2024 13:44
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1618 +/- ##
==========================================
+ Coverage 84.31% 84.33% +0.01%
==========================================
Files 121 122 +1
Lines 5566 5630 +64
==========================================
+ Hits 4693 4748 +55
- Misses 619 627 +8
- Partials 254 255 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: wangxiaoxuan273 <wangxiaoxuan119@gmail.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
oras blob push commandoras blob push command
Wwwsylvia
reviewed
Feb 19, 2025
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
shizhMSFT
reviewed
Feb 19, 2025
Contributor
added 2 commits
February 20, 2025 16:05
added 2 commits
February 20, 2025 16:19
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
shizhMSFT
approved these changes
Feb 20, 2025
shizhMSFT
left a comment
Contributor
There was a problem hiding this comment.
LGTM with suggestions. Nice catch on the Exists UI bug.
Wwwsylvia
reviewed
Feb 21, 2025
added 2 commits
February 25, 2025 14:41
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The
oras blob pushon the main branch has several problems.Printer.Printlnfor status and metadata output, instead of handlers.--descriptoris used, status output is still shown but nothing should be printed except the descriptor.This PR fixes all the above issues and refactors the code to use status, metadata and content handlers.
Current display:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #1542
Please check the following list: