Skip to content

fix: mark --oci-layout-path as experimental#1607

Merged
TerryHowe merged 2 commits into
oras-project:mainfrom
Horiodino:experimental
Jan 21, 2025
Merged

fix: mark --oci-layout-path as experimental#1607
TerryHowe merged 2 commits into
oras-project:mainfrom
Horiodino:experimental

Conversation

@Horiodino

@Horiodino Horiodino commented Jan 16, 2025

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

marked --oci-layout-path as experimental

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1582

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Horiodino <holiodin@gmail.com>
@codecov

codecov Bot commented Jan 17, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.30%. Comparing base (8a31d9b) to head (45a5764).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1607      +/-   ##
==========================================
- Coverage   84.34%   84.30%   -0.04%     
==========================================
  Files         120      120              
  Lines        5449     5449              
==========================================
- Hits         4596     4594       -2     
- Misses        606      608       +2     
  Partials      247      247              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment thread cmd/oras/internal/option/target.go
@Horiodino

Horiodino commented Jan 18, 2025

Copy link
Copy Markdown
Contributor Author

I’m not sure I understand the need for a test case for that, as I’ve checked and all tests pass locally.

@Wwwsylvia Wwwsylvia left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with suggestions

@shizhMSFT shizhMSFT changed the title marked --oci-layout-path as experimental fix: mark --oci-layout-path as experimental Jan 21, 2025

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

--oci-layout-path should be marked as experimental

4 participants