Skip to content

fix: add digest to fetched status output of manifest index create#1579

Merged
TerryHowe merged 2 commits into
oras-project:mainfrom
wangxiaoxuan273:index-fetch-print
Dec 26, 2024
Merged

fix: add digest to fetched status output of manifest index create#1579
TerryHowe merged 2 commits into
oras-project:mainfrom
wangxiaoxuan273:index-fetch-print

Conversation

@wangxiaoxuan273

@wangxiaoxuan273 wangxiaoxuan273 commented Dec 10, 2024

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:
Display after change
image

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1576

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
@codecov

codecov Bot commented Dec 10, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.30%. Comparing base (b72d1f5) to head (af14715).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1579      +/-   ##
==========================================
- Coverage   84.33%   84.30%   -0.03%     
==========================================
  Files         120      120              
  Lines        5446     5449       +3     
==========================================
+ Hits         4593     4594       +1     
- Misses        606      608       +2     
  Partials      247      247              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@qweeah qweeah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe TerryHowe merged commit 836c497 into oras-project:main Dec 26, 2024
@wangxiaoxuan273 wangxiaoxuan273 deleted the index-fetch-print branch January 7, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent output in "oras manifest index create"

3 participants