refactor: add metadata render interface and apply it to oras attach command#1578
Merged
Conversation
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
oras attach to have no parameterOnCompleted of oras attach to have no parameter
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1578 +/- ##
==========================================
+ Coverage 84.29% 84.33% +0.03%
==========================================
Files 120 120
Lines 5401 5413 +12
==========================================
+ Hits 4553 4565 +12
Misses 602 602
Partials 246 246 ☔ View full report in Codecov by Sentry. |
qweeah
reviewed
Dec 10, 2024
qweeah
reviewed
Dec 10, 2024
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
OnCompleted of oras attach to have no parameteroras attach command
4 tasks
6 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #1573
Please check the following list: