refactor: mark --verbose as deprecated#1558
Merged
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1558 +/- ##
==========================================
- Coverage 84.07% 84.05% -0.02%
==========================================
Files 119 119
Lines 5325 5331 +6
==========================================
+ Hits 4477 4481 +4
- Misses 602 604 +2
Partials 246 246 ☔ View full report in Codecov by Sentry. |
Member
|
Maybe mark it deprecated in the Printer object too |
Member
Author
Currently it is still functioning, we can consider removing the whole verbose stuff in v1.4.0 or something? |
c36f837 to
b179510
Compare
Member
Author
|
@TerryHowe This is now ready for review. |
4680d74 to
654d68c
Compare
qweeah
reviewed
Dec 5, 2024
qweeah
reviewed
Dec 5, 2024
qweeah
reviewed
Dec 5, 2024
qweeah
reviewed
Dec 5, 2024
qweeah
reviewed
Dec 5, 2024
FeynmanZhou
reviewed
Dec 5, 2024
FeynmanZhou
left a comment
Member
There was a problem hiding this comment.
The examples align with the spec and look good to me. Thanks @Wwwsylvia
Member
|
@TerryHowe would you mind taking a look at this PR? |
adb16ec to
ddcf411
Compare
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
7ac5d4a to
e171d73
Compare
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
--verboseflag as deprecated and print verbose output by default for the following six commands. As a result, the--verboseflag will be hidden in the help doc, and there will be a warning message when--verboseis specified.oras pushoras pulloras attachoras cporas manifest pushoras blob pushThe deprecation of
--verbosefororas discoverwill be addressed with #1534.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1533
Prerequisite: #1553
Examples:
oras pullBEFORE:oras pullAFTER:oras pull --verboseBEFORE:oras pull --verboseAFTER:oras pull --verbose=falseBEFORE:oras pull --verbose=falseAFTER:oras pull --helpBEFORE:oras pull --helpAFTER:Please check the following list: