Skip to content

feat: add OS/Arch information into oras version#1556

Merged
qweeah merged 4 commits into
oras-project:mainfrom
wangxiaoxuan273:version
Dec 3, 2024
Merged

feat: add OS/Arch information into oras version#1556
qweeah merged 4 commits into
oras-project:mainfrom
wangxiaoxuan273:version

Conversation

@wangxiaoxuan273

@wangxiaoxuan273 wangxiaoxuan273 commented Dec 2, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

Current display:
image

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1536

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

Add OS/Arch information into oras version
224527d 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
@wangxiaoxuan273 wangxiaoxuan273 changed the title Add OS/Arch information into oras version feat: add OS/Arch information into oras version Dec 2, 2024
@codecov

codecov Bot commented Dec 2, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.98%. Comparing base (325572c) to head (3b2c53e).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1556   +/-   ##
=======================================
  Coverage   83.98%   83.98%           
=======================================
  Files         119      119           
  Lines        5314     5315    +1     
=======================================
+ Hits         4463     4464    +1     
  Misses        604      604           
  Partials      247      247

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Xiaoxuan Wang added 2 commits December 2, 2024 15:49
add test
b8122c5 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
add new test
7a71d9d 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
@wangxiaoxuan273 wangxiaoxuan273 marked this pull request as ready for review December 2, 2024 08:20
shizhMSFT
shizhMSFT approved these changes Dec 2, 2024
View reviewed changes

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TerryHowe
TerryHowe approved these changes Dec 2, 2024
View reviewed changes
Comment thread test/e2e/suite/command/version_darwin.go
@qweeah qweeah merged commit 2703462 into oras-project:main Dec 3, 2024
@wangxiaoxuan273 wangxiaoxuan273 deleted the version branch December 3, 2024 01:42
@qweeah qweeah mentioned this pull request Dec 9, 2024
Merged
@Wwwsylvia Wwwsylvia mentioned this pull request Sep 3, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Wwwsylvia Wwwsylvia Wwwsylvia left review comments

@TerryHowe TerryHowe TerryHowe approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

@qweeah qweeah Awaiting requested review from qweeah

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add OS/Arch information into oras version

5 participants

@wangxiaoxuan273 @TerryHowe @qweeah @Wwwsylvia @shizhMSFT