fix: force config media type when setting platform#1519
Merged
Conversation
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1519 +/- ##
=======================================
Coverage 83.86% 83.87%
=======================================
Files 118 118
Lines 5164 5166 +2
=======================================
+ Hits 4331 4333 +2
Misses 592 592
Partials 241 241 ☔ View full report in Codecov by Sentry. |
shizhMSFT
reviewed
Oct 30, 2024
Signed-off-by: Billy Zha <jinzha1@microsoft.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
When selecting a platform, oras-go only allows config type to be
application/vnd.oci.image.config.v1+json. See https://github.com/oras-project/oras-go/blob/v2.5.0/internal/platform/platform.go#L110.This PR enforces above design with 2 changes:
config.mediaTypeis set toapplication/vnd.oci.image.config.v1+jsonwhen baking platform into the config blob;oras push --artifact-type xxx -artifact-platform xxx --image-spec v1.0 ...is banned.Without this PR,
oras pushmight generate artifacts that cannot be consumed byoras pull --platform, see #1517 (comment)Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #1517
Please check the following list: