fix: platform config type#1518
Merged
Merged
Conversation
682272a to
68be654
Compare
Member
|
Looks like some E2E tests failed |
68be654 to
8535ad1
Compare
Signed-off-by: Terry Howe <terrylhowe@gmail.com>
8535ad1 to
7578a00
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1518 +/- ##
=======================================
Coverage 83.84% 83.84%
=======================================
Files 118 118
Lines 5156 5156
=======================================
Hits 4323 4323
Misses 592 592
Partials 241 241 ☔ View full report in Codecov by Sentry. |
Member
Author
Fixed. |
Wwwsylvia
approved these changes
Oct 29, 2024
Wwwsylvia
left a comment
Member
There was a problem hiding this comment.
LGTM, but I am not a maintainer
4 tasks
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix platform config type.
Which issue(s) this PR fixes
Fixes #1517