feat: --annotation for index create#1499
Merged
qweeah merged 15 commits intoSep 23, 2024
Merged
Conversation
added 2 commits
September 13, 2024 15:55
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
c327d6e to
d7cb253
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1499 +/- ##
==========================================
+ Coverage 86.01% 86.10% +0.08%
==========================================
Files 117 118 +1
Lines 4226 4224 -2
==========================================
+ Hits 3635 3637 +2
+ Misses 353 350 -3
+ Partials 238 237 -1 ☔ View full report in Codecov by Sentry. |
index createindex create
index create--annotation, --annotation-file for index create
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
d7cb253 to
87817c8
Compare
--annotation, --annotation-file for index create--annotation for index create
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
added 2 commits
September 18, 2024 11:34
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
wangxiaoxuan273
commented
Sep 18, 2024
added 6 commits
September 19, 2024 15:08
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
Wwwsylvia
approved these changes
Sep 19, 2024
Wwwsylvia
left a comment
Member
There was a problem hiding this comment.
LGTM. But I am not a maintainer.
shizhMSFT
requested changes
Sep 20, 2024
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
24c3248 to
6b0349b
Compare
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
qweeah
approved these changes
Sep 23, 2024
qweeah
left a comment
Contributor
There was a problem hiding this comment.
LGTM with minor suggestions.
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #1053
Please check the following list: