Skip to content

build: upgrade to Go 1.23.0#1493

Merged
shizhMSFT merged 1 commit into
oras-project:mainfrom
Wwwsylvia:bump_go
Sep 3, 2024
Merged

build: upgrade to Go 1.23.0#1493
shizhMSFT merged 1 commit into
oras-project:mainfrom
Wwwsylvia:bump_go

Conversation

@Wwwsylvia

@Wwwsylvia Wwwsylvia commented Aug 30, 2024

Copy link
Copy Markdown
Member

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1492

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@Wwwsylvia Wwwsylvia changed the title build: upgrade to go 1.23.0 build: upgrade to Go 1.23.0 Aug 30, 2024
@github-advanced-security

github-advanced-security AI commented Aug 30, 2024

Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@codecov

codecov Bot commented Aug 30, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.54%. Comparing base (749d2ff) to head (ee54c02).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1493      +/-   ##
==========================================
- Coverage   85.59%   85.54%   -0.06%     
==========================================
  Files         113      113              
  Lines        3936     3936              
==========================================
- Hits         3369     3367       -2     
- Misses        340      342       +2     
  Partials      227      227

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

TerryHowe
TerryHowe approved these changes Aug 31, 2024
View reviewed changes

@TerryHowe TerryHowe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@TerryHowe

TerryHowe commented Aug 31, 2024

Copy link
Copy Markdown
Member

Hold this for oras-go?

@shizhMSFT

shizhMSFT commented Sep 2, 2024

Copy link
Copy Markdown
Contributor

Hold this for oras-go?

Not necessary but good to do so.

shizhMSFT
shizhMSFT approved these changes Sep 2, 2024
View reviewed changes

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Wwwsylvia

Wwwsylvia commented Sep 2, 2024

Copy link
Copy Markdown
Member Author

oras-go is now at Go 1.22.

@Wwwsylvia
upgrade to go 1.23.0
ee54c02 
Signed-off-by: Lixia (Sylvia) Lei <lixlei@microsoft.com>
@shizhMSFT shizhMSFT merged commit 4c88cb8 into oras-project:main Sep 3, 2024
@shizhMSFT shizhMSFT added this to the v1.3.0 milestone Sep 3, 2024
@Wwwsylvia Wwwsylvia deleted the bump_go branch September 3, 2024 06:55
@qweeah qweeah mentioned this pull request Dec 9, 2024
Merged
@Wwwsylvia Wwwsylvia mentioned this pull request Sep 3, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TerryHowe TerryHowe TerryHowe approved these changes

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

@qweeah qweeah Awaiting requested review from qweeah

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.3.0

Development

Successfully merging this pull request may close these issues.

Upgrade Go version to 1.23

4 participants

@Wwwsylvia @github-advanced-security @TerryHowe @shizhMSFT