Skip to content

feat: --output for oras manifest index create#1490

Merged
shizhMSFT merged 5 commits into
oras-project:mainfrom
wangxiaoxuan273:create-output
Sep 12, 2024
Merged

feat: --output for oras manifest index create#1490
shizhMSFT merged 5 commits into
oras-project:mainfrom
wangxiaoxuan273:create-output

Conversation

@wangxiaoxuan273

@wangxiaoxuan273 wangxiaoxuan273 commented Aug 29, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

What this PR does / why we need it:

current output:

oras manifest index create myregistry.azurecr.io/test sha256:42c524c48e0672568dbd2842d3a0cb34a415347145ee9fe1c8abaf65e7455b46 --output - --pretty
Fetching sha256:42c524c48e0672568dbd2842d3a0cb34a415347145ee9fe1c8abaf65e7455b46
Fetched  sha256:42c524c48e0672568dbd2842d3a0cb34a415347145ee9fe1c8abaf65e7455b46
Packed   f16df862b7e3 application/vnd.oci.image.index.v1+json
Digest: sha256:f16df862b7e3d4f13c03d59655ed25a71a68e01e4aeec0d921d7310d6c67a360
{
  "schemaVersion": 2,
  "mediaType": "application/vnd.oci.image.index.v1+json",
  "manifests": [
    {
      "mediaType": "application/vnd.oci.image.manifest.v1+json",
      "digest": "sha256:42c524c48e0672568dbd2842d3a0cb34a415347145ee9fe1c8abaf65e7455b46",
      "size": 1239,
      "platform": {
        "architecture": "amd64",
        "os": "linux"
      }
    }
  ]
}

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Part of #1053

Please check the following list:

  • Does the affected code have corresponding tests, e.g. unit test, E2E test?
  • Does this change require a documentation update?
  • Does this introduce breaking changes that would require an announcement or bumping the major version?
  • Do all new files have an appropriate license header?

@wangxiaoxuan273 wangxiaoxuan273 changed the title Create output feat: --output for index create Aug 29, 2024
@wangxiaoxuan273 wangxiaoxuan273 changed the title feat: --output for index create feat: --export-manifest for index create Sep 2, 2024
@codecov

codecov Bot commented Sep 2, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.83%. Comparing base (0baec35) to head (d7055ad).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1490      +/-   ##
==========================================
+ Coverage   85.73%   85.83%   +0.09%     
==========================================
  Files         116      116              
  Lines        4059     4073      +14     
==========================================
+ Hits         3480     3496      +16     
+ Misses        347      345       -2     
  Partials      232      232

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wangxiaoxuan273 wangxiaoxuan273 changed the title feat: --export-manifest for index create feat: --output for oras manifest index create Sep 12, 2024
Xiaoxuan Wang added 4 commits September 12, 2024 18:43
rebased
7cb0ac8 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
fix example
e7c447b 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
output
6f6de25 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
added e2e tests
12a8e6b 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
@wangxiaoxuan273 wangxiaoxuan273 marked this pull request as ready for review September 12, 2024 10:44
refinement
d7055ad 
Signed-off-by: Xiaoxuan Wang <xiaoxuanwang@microsoft.com>
shizhMSFT
shizhMSFT approved these changes Sep 12, 2024
View reviewed changes

@shizhMSFT shizhMSFT left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shizhMSFT shizhMSFT merged commit a3b0601 into oras-project:main Sep 12, 2024
@qweeah

qweeah commented Sep 13, 2024

Copy link
Copy Markdown
Contributor

Shouldn't --output - forbids status output?

@wangxiaoxuan273

wangxiaoxuan273 commented Sep 13, 2024

Copy link
Copy Markdown
Contributor Author

Shouldn't --output - forbids status output?

Is it necessary?

@qweeah

qweeah commented Sep 13, 2024

Copy link
Copy Markdown
Contributor

I think it's intuitive and conventional. E.g. curl turns off status output when using -o -.

@wangxiaoxuan273 wangxiaoxuan273 deleted the create-output branch September 23, 2024 02:08
@qweeah qweeah mentioned this pull request Dec 9, 2024
Merged
@Wwwsylvia Wwwsylvia mentioned this pull request Sep 3, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shizhMSFT shizhMSFT shizhMSFT approved these changes

@sajayantony sajayantony Awaiting requested review from sajayantony sajayantony is a code owner

@SteveLasker SteveLasker Awaiting requested review from SteveLasker

@qweeah qweeah Awaiting requested review from qweeah

@TerryHowe TerryHowe Awaiting requested review from TerryHowe TerryHowe is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wangxiaoxuan273 @qweeah @shizhMSFT